Fix for xarray 2024.09.0 #1920
Fix for xarray 2024.09.0 #1920
Conversation
|
I'll let you decide how to manage the git stuff 😅 |
There was a problem hiding this comment.
OK, we're going to need to rebase this PR onto the v0.52.1 tag, if that's alright. If you want to do the following, this would be helpful:
Start a new branch based on thev0.52.1tag (v0.52.2).git cherry-pickyour commits to the new branch.Open a PR and do not merge main into it
I can take things from there.
Scratch all of that. Working from here, see if you can get things working. There should be exactly two failing tests in all builds at the moment. I'll mark.xfail them here (they're removed in main) so that we can verify there aren't slower builds failing with unexpected failures.
Zeitsperre
force-pushed
the
fix-xr-decimalyr
branch
from
0fa7e37 to
1b012e7
Compare
|
There's a bug with intersphinx for statsmodel, maybe just a retry could solve it ? And the notebook CI doesn't seem aware that it should use the old version of xclim-testdata... |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Well, this could have been expected from my decision to use a private function that I myself removed... But I had forgotten that we were explicitly using it.
So this fixes xclim with xarray 2024.09.0 by having a try-except for the import of the decimal year stuff.
Also, removed the deprecated function.
As of xarray 2024.09, the "decimal year" can be calculated through
times.dt.decimal_year, no need to use a private function.